Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only resolve dependencies if necessary. Fixes #831. #861

Merged
merged 2 commits into from
Jun 4, 2016

Conversation

s-ludwig
Copy link
Member

@s-ludwig s-ludwig commented Jun 2, 2016

This avoids the default dependency resolution pass to search for missing dependencies if all dependencies are satisfied already.

This avoids the default dependency resolution pass to search for missing dependencies if all dependencies are satisfied already.
If no dub.selections.json file exists, trigger dependency resolution if a default optional dependency is missing.
@s-ludwig s-ludwig added this to the 1.0.0 milestone Jun 4, 2016
@andralex
Copy link
Member

andralex commented Jun 4, 2016

going on a limb here :)

@andralex andralex merged commit 6cc5055 into master Jun 4, 2016
@s-ludwig s-ludwig deleted the issue831-superfluous-registry-query branch June 5, 2016 19:33
@MartinNowak
Copy link
Member

Another approach which would also allow partial updates of dependencies would be to sort the selected versions to the front of the available version, thus starting with resolving the current selection.
But for a normal build, not resolving anything makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants